QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
154 stars 84 forks source link

Incorrect translation method causes "%s" disconnect errors #325

Closed TropheusJ closed 1 year ago

TropheusJ commented 1 year ago

I've noticed this disconnect screen appearing somewhat often: image

I found a case where a placeholder is not being filled in, and the content is being used as a fallback instead, here Mojmap makes this mistake much clearer: image disconnect.genericReason translates to %s, which should be filled in by the next string. A recent update added methods that allow for a fallback when no translation is available. The wrong method is being used here. This is one case I found, but there are probably more elsewhere. All uses should be checked.

Patbox commented 1 year ago

Updating mappings might fix that, as it was fixed there