QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
154 stars 84 forks source link

Remove nether param. range list caching, fixing #332 #333

Closed cocona20xx closed 1 year ago

cocona20xx commented 1 year ago

Don't exactly understand why this works, but presumably the value stored in quilt$CACHED_PARAMETER_RANGE_LIST wasn't being nulled when a world was unloaded, leading to the funky behavior on second world's nether load There's probably a better way to impl. this fix, but since @EnnuiL mentioned in the discord she might change this part of the Biomes API heavily soon anyways, this'll do for now as a quickfix

EnnuiL commented 1 year ago

While I've went with the approach of switching back to an older method, I appreciate the efforts here! It did show that the newer method could be fixed and that is important, because I still don't discard a future where it might end being needed again :p I should perhaps get deeper into like, a profiling habit though, in order to actually measure potential lag and such