search

QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
152 stars 85 forks source link

1.19.4 feature backports #347

Closed cocona20xx closed 11 months ago

cocona20xx commented 11 months ago

Backports the following changes required for or related to QFAPI sync:

Also ran the licenser, which created... quite the few file changes that were just updating copyright year numbers. Tell me if I should revert that or not, please.

If there's more that needs to be done please let me know, this is a draft PR for a reason—I'm not sure if I caught everything that's absolutely necessary!

OroArmor commented 11 months ago

Are you on windows? That messes up the licenser. If you revert the commit i can push a commit with the correct headers.

cocona20xx commented 11 months ago

Are you on windows? That messes up the licenser

nope, I'm on macOS, and it's worked fine in the past. If the headers are malformated in this case too, it might be a more general issue with the copyright year incrementing function? Also, looking at the headers they all look fine, as mentioned prior it's almost all just updating the copyright year range to contain 2023

OroArmor commented 11 months ago

Hm interesting. Not sure at all, but yeah i would revert that last commit for now

EnnuiL commented 11 months ago

Are you on windows? That messes up the licenser

nope, I'm on macOS, and it's worked fine in the past. If the headers are malformated in this case too, it might be a more general issue with the copyright year incrementing function? Also, looking at the headers they all look fine, as mentioned prior it's almost all just updating the copyright year range to contain 2023

The fix would be to backport the license header change, since yeah, the range is a lost cause

cocona20xx commented 11 months ago

Are you on windows? That messes up the licenser

nope, I'm on macOS, and it's worked fine in the past. If the headers are malformated in this case too, it might be a more general issue with the copyright year incrementing function? Also, looking at the headers they all look fine, as mentioned prior it's almost all just updating the copyright year range to contain 2023

The fix would be to backport the license header change, since yeah, the range is a lost cause

Ah, uh, how would that be done? Discussion is going on when it comes to licenser bs in the discord as well fyi, that's probably a better place to handle this technicality specifically.

cocona20xx commented 11 months ago

Other than the licenser issues, this should be good to go ahead. Going to make it into a normal PR.