Support for 1.20.3/4 - Githubissues

QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.

Apache License 2.0

152 stars 85 forks source link

Support for 1.20.3/4 #356

Closed moehreag closed 6 months ago

moehreag commented 9 months ago

Tasks:

[ ] decide on which version this should get (please just edit it in before merging)
[ ] possibly create a new branch for this pr to target
[ ] figure out a solution for the test mods as they currently do not get loaded correctly because loom requires the mods block

Information: builds succeed, but gradle will still spit out errors about the javadocs as well as about not finding some of minecraft's classes. I don't know if these "errors" were present before, but the mod works fine.

OroArmor commented 9 months ago

Looks good from a cursory glance. Once I have time to fix 1.20.2, I'll merge that into this and then make a new 1.20.3 branch for 1.20.3/4 and then merge this

FirstMegaGame4 commented 6 months ago

Why is the target branch named 1.20.3 and not 1.20.4? 1.20.3 is just 1.20.4 with a missing markDirty

OroArmor commented 6 months ago

20.3 and 20.4 are compatible. if we updated on time, we would stay on the 20.3 branch and add support from there.