QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.

Apache License 2.0

152 stars 85 forks source link

`QuiltBlockSettings` copy constructor does not copy `burnable` flag #357

Closed Kneelawk closed 9 months ago

Kneelawk commented 9 months ago

The Issue

While looking over https://github.com/FabricMC/fabric/pull/3373 I noticed that QSL's implementation was missing copying the burnable flag. This appears to be the only thing QSL is missing from the referenced PR.

Kneelawk commented 9 months ago

I'm investigating this more now, and I can't seem to find burnable in the AbstractBlock.Settings class, even though it is referenced in an FAPI mixin.

Kneelawk commented 9 months ago

Ok, turns out burnable is called lavaIgnitable in QM and I didn't notice FAPI didn't have it the first time over. So QSL does actually copy the burnable flag, just under another name.