search

QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
152 stars 85 forks source link

Bad mod compatibility with mixin into resource reloading #358

Closed MattiDragon closed 1 month ago

MattiDragon commented 8 months ago

QSL uses a mixin into ServerReloadableResources#getReloaders that injects its own reloaders into the vanilla system. For this it uses an unconditionally canceling mixin at RETURN which causes issues with other mixins (primarily from fabric mods without the same apis available). This issue is specifically bad as it depends on mod load order and causes mod resources to silently not be loaded due to QSL canceling the method before they get to do anything.

I suggest that this be fixed by replacing the mixin with a @ModifyReturnValue from mixin extras so that your modifications stack with those of other mods. The specific offending injector can be found here.

Originally reported as MattiDragon/ExtendedDrawers#88.

ix0rai commented 1 month ago

this has been fixed by https://github.com/QuiltMC/quilt-standard-libraries/commit/b10c5caad01928d2cecda1b0d94fb0b66c3fcfcb !