QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
152 stars 85 forks source link

Fix Recipe Remainder API #366

Closed OroArmor closed 5 months ago

OroArmor commented 5 months ago

A fairly substantial rework of the Recipe Remainder API.

The main idea behind this change is that the vanilla recipe remainders are used in two different contexts, and only those two (Crafting and Furnace Fuel). By arbitrarily extending this to all the supported locations, mods that relied on the behavior only being used in the vanilla locations broke. A great example was smelting a water bucket into a steam bucket, and duping the bucket (#251).

This PR fixes this by forcing mods to explicitly register their remainders for different locations than the default vanilla ones. This is a breaking change to the API, but no mods will crash, only their functionality will be impacted.

This PR also fixes the remainders not working in the new smithing table and extends the system to work in both the template and base slots.

Fixes #251

OroArmor commented 5 months ago

FCP for 2 days.