MC-259583 - Last potion ingredient is deleted. - Githubissues

QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.

Apache License 2.0

152 stars 85 forks source link

MC-259583 - Last potion ingredient is deleted. #376

Open OroArmor opened 5 months ago

OroArmor commented 5 months ago

We supposedly fix https://bugs.mojang.com/browse/MC-259583 but it appears to not be so. This is a problem and leads to item deletion.

See also: https://github.com/FabricMC/fabric/issues/2873.

Locations to look: https://github.com/QuiltMC/quilt-standard-libraries/blob/009a672bba4126fb4012258d7f39a2f6dc4d1771/library/item/item_setting/src/main/java/org/quiltmc/qsl/item/setting/mixin/recipe_remainder/BrewingStandBlockEntityMixin.java#L40-L54 https://github.com/QuiltMC/quilt-standard-libraries/blob/009a672bba4126fb4012258d7f39a2f6dc4d1771/library/item/item_setting/src/main/java/org/quiltmc/qsl/item/setting/mixin/recipe_remainder/ItemsMixin.java#L45-L51

maloryware commented 2 weeks ago

Is it worth fixing this behavior? Looking at the Fabric issue, this would mean losing vanilla parity and possibly breaking automated potion crafting farms.