QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
152 stars 85 forks source link

Potential hard-locking for Tracked Data Handlers #385

Open OroArmor opened 2 weeks ago

OroArmor commented 2 weeks ago

Describe the bug

A combination of mixin ordering (we are added after another mod) plus the mod causing the issue not being the development mod could hard lock a game by crashing on startup.

In addition, if a mod injects at the top of <clinit> and registers null, we then believe that is the BYTE handler, causing another crash.

How did QSL break?

https://github.com/QuiltMC/quilt-standard-libraries/blob/cbd35a1dec69242d376e26bb1aaa72262e48cd82/library/entity/entity_extensions/src/main/java/org/quiltmc/qsl/entity/extensions/mixin/networking/TrackedDataHandlerRegistryMixin.java#L139-L141

Which environment did you encounter this bug in?

Both

Logs

No response