search

QuiltMC / quilted-fabric-api

Re-implementation of the Fabric API using QSL as implementation instead.
Apache License 2.0
85 stars 32 forks source link

FAPI 0.86.1 sync #111

Closed cocona20xx closed 1 year ago

cocona20xx commented 1 year ago

Is seemingly mostly functional, but there's a chance I missed something somewhere, and this port also requires extensive testing against FAPI 0.86.0, current QSL, and vanilla for the recently added FAPI Dynamic Registries.

The other changes, including the new Fabric Model Loading API and small additions to the Fabric Transfer API, are seemingly drag-and-drop and did not require significant edits to make functional.

cocona20xx commented 1 year ago

Waiting on https://github.com/QuiltMC/quilt-standard-libraries/pull/329 and https://github.com/QuiltMC/quilt-standard-libraries/pull/330 to be merged and a new minor release of QSL to be released containing said fixes/additions to continue on this, as both features will heavily simply what QFAPI needs to come in sync with 0.86.0 and 0.86.1

On that subject, should QFAPI skip 0.86.0 and only provide support for 0.86.1? The latter is pretty much all bugfixes, so it seems like a reasonable thing to do, but I'm not sure.

ix0rai commented 1 year ago

yes, we skip versions that release between updates so we'll go straight to 0.86.1!

cocona20xx commented 1 year ago

While waiting for QSL prs 330 and 329 to be merged, going to look into fixing #112, #109, #108, and possibly #69, since those aren't reliant on QSL changes edit: 112 apparently is already fixed. guh. edit 2 ~ tokyo drift: Found the fix for #109, it's in https://github.com/QuiltMC/quilt-standard-libraries/pull/333 edit the third: #108 doesn't seem to actually be real in pure QSL + QFAPI, hopefully

cocona20xx commented 1 year ago

With the latest commit, QFAPI should be ready for testing and one final review pass! Going to set this as a ready PR now.