Added a Guide for making Pull Requests

QuiltMC / quilted-fabric-api

Re-implementation of the Fabric API using QSL as implementation instead.

Apache License 2.0

87 stars 32 forks source link

Added a Guide for making Pull Requests #117

Closed Redfan2 closed 1 year ago

Redfan2 commented 1 year ago

Hi, I added a guide for asking Pull Requests to the CONTRIBUTING.md. I also linked to the Fabric Development Guidelines as they make a good job describing everything related to the style of Code contributions. If you have more Ideas for things which belong into a PR comment, please give feedback.

ix0rai commented 1 year ago

hey, in its current state this isn't terribly useful. would you mind updating this to be more QFAPI-specific, as in more info on how to sync upstream from fabric, test, etc?

Redfan2 commented 1 year ago

Hi. No, I'm not able to update this to cover more as I do not have any experience with developing QFAPI. I wrote this guide because it was missing and didn't require technical knowledge of the internals. Feel free to close or rename it. In hindsight I don't know why I decided to make a PR for such a small change

ix0rai commented 1 year ago

alright, I'll toss it on my todo. thank you for the pr anyway!