This PR inverts the QSL wasDeath flag when translating it into FAPI alive flag in the ServerPlayerEvents.CopyFrom event. The FAPI alive flag indicates whether the old player is still alive. The QSL wasDeath flag indicates whether the copy was due to the old player dying. Generally, these two flags should be opposites of each other.
Testing
I have tested this PR with the Soulbound Enchantments mod (which is how I discovered this bug in the first place) and inverting this flag fixes the issues I was experiencing.
EnnuiL
commented
1 year ago
This PR
This PR inverts the QSL
wasDeathflag when translating it into FAPIaliveflag in theServerPlayerEvents.CopyFromevent. The FAPIaliveflag indicates whether the old player is still alive. The QSLwasDeathflag indicates whether the copy was due to the old player dying. Generally, these two flags should be opposites of each other.Testing
I have tested this PR with the Soulbound Enchantments mod (which is how I discovered this bug in the first place) and inverting this flag fixes the issues I was experiencing.