search

QuiltMC / quiltmc.org

The source for quiltmc.org
https://quiltmc.org
Other
58 stars 48 forks source link

Teams: Github sync & Lead display #117

Closed Akarys42 closed 1 year ago

Akarys42 commented 1 year ago

This PR makes the team page pull information directly from GitHub. It also adds a star to team leads and does some small updates to the team data.

Missing profiles have been handled correctly to avoid PRs breaking due to an external factor.

See preview on Cloudflare Pages: https://preview-117.quiltmc-org.pages.dev

gdude2002 commented 1 year ago

Is this actually ready for review? The initial PR comment suggests that it should be WIP.

Akarys42 commented 1 year ago

The logic can be reviewed, although we're still waiting on the admin board to sort out github teams.

Akarys42 commented 1 year ago

Everything has been updated, this PR is ready for merge

pluiedev commented 1 year ago

Oh, there is one small problem with the team info that's being fetched: quilt-standard-libraries and quilt-standard-library-leaders escape from the standard of everyone else's, making the "append the suffix" strategy fail there and making the team leaders fail to be read

I mean couldn't we just make QSL consistent with the rest? I don't think we ever call it "Quilt Standard Library" anyway

EnnuiL commented 1 year ago

Oh, there is one small problem with the team info that's being fetched: quilt-standard-libraries and quilt-standard-library-leaders escape from the standard of everyone else's, making the "append the suffix" strategy fail there and making the team leaders fail to be read

I mean couldn't we just make QSL consistent with the rest? I don't think we ever call it "Quilt Standard Library" anyway

Yeah, this is what I was thinking: rename quilt-standard-library-leaders to quilt-standard-libraries-leaders; I just failed to like, verbalize that :p