Cook the incompatible mod list

QuiltMC / quiltmc.org

The source for quiltmc.org

https://quiltmc.org

Other

58 stars 44 forks source link

Cook the incompatible mod list #196

Closed simpledemonn closed 3 months ago

simpledemonn commented 3 months ago

Move the endpoint inside the API (with redirect)
Add icons, status, and tracking issues
Remove old entries that are already fixed
Make a HTML view for the page

Please note the unknown mod icon will not work until the PR is merged, since the data hardcode the domain for better interaction with third parties.

See preview on Cloudflare Pages: https://preview-196.quiltmc-org.pages.dev

OroArmor commented 3 months ago

Unknown mod icon does not work.

These are unclear what they mean:

simpledemonn commented 3 months ago

Unknown mod icon does not work.

These are unclear what they mean:

You can hover the symbol on the left to know what it means. I forgot to add a hover to the symbol on the right, I could do that.

simpledemonn commented 3 months ago

Added to the PR description:

Please note the unknown mod icon will not work until the PR is merged, since the data hardcode the domain for better interaction with third parties.

OroArmor commented 3 months ago

simpledemonn commented 3 months ago

idfk what happened but it is fixed

ix0rai commented 3 months ago

decompiling fast leaf decay (https://modrinth.com/mod/fld/) doesn't show any code that crashes Quilt. i'm curious where the original report came from, as Hydos has been antagonistic against Quilt in the past

simpledemonn commented 3 months ago

decompiling fast leaf decay (https://modrinth.com/mod/fld/) doesn't show any code that crashes Quilt. i'm curious where the original report came from, as Hydos has been antagonistic against Quilt in the past

It is probably somewhere in the forums so who knows. Do we just remove it then?

anonymous123-code commented 3 months ago

I defintely found something in the version on cf: https://www.curseforge.com/minecraft/mc-mods/fld, It (1.1.0) contains a client side mixin called MinecraftMixin, which displays a custom screen called LeafDecayPHCWScreen when quilt is detected

quinn-semele commented 3 months ago

I defintely found something in the version on cf: https://www.curseforge.com/minecraft/mc-mods/fld, It (1.1.0) contains a client side mixin called MinecraftMixin, which displays a custom screen called LeafDecayPHCWScreen when quilt is detected

Can confirm existance in decompiled code but tbh it's proving hard to actually get said screen to show in practice. Tried with 1.19.2, 1.19.4 and 1.20.2 (which is listed as supported). Screen doesn't seem to show on either 1.19.2 or 1.19.4 and well the mod just simply doesn't work on 1.20.2...

Oh right the mixin isn't even referenced from the mixin file, it's just dead code...