Closed UpcraftLP closed 2 months ago
Question : will this include the swagger JS on every page ? If so, how heavy is it ?
No, it will not.
It will only load that on the /api
page
Anything blocking this? This has been drafted for a month.
if you check the preview, you'll see that this PR completely breaks i18n
I see. How has such an issue not been fixed in a month's time? Surely it should take at most a week.
quilt is all volunteer work, so we can't expect our contributors to always promptly fix issues. one good thing about open source is that someone else can always pick up the work!
I see. How has such an issue not been fixed in a month's time? Surely it should take at most a week.
Surely it should also not be using an ancient version of astro and ancient versions of dependencies that break if you update, but here we are.
Feel free to check out the changes of this PR and fix the issues with it.
The styling is a bit odd on dark mode, could that be changed?
Ah, I see you've actually addressed the CSS in your original request
Question: The page on https://quiltmc.org/api/ is working fine for me, is there something I'm missing?
seems like the astro update may have fixed it!
Well, brilliant!
This PR fixes the api docs page by replacing the previous hackjob with a dedicated swagger-ui package built for astro.
See preview on Cloudflare Pages: https://preview-232.quiltmc-org.pages.dev