QuiltMC / quiltmc.org

The source for quiltmc.org
https://quiltmc.org
Other
58 stars 49 forks source link

Fix API page #232

Closed UpcraftLP closed 2 months ago

UpcraftLP commented 4 months ago

This PR fixes the api docs page by replacing the previous hackjob with a dedicated swagger-ui package built for astro.

[!NOTE]
Custom CSS seems to be broken, but will have to be fixed at a later date. Right now having a slightly-bad-looking API page is better than none at all.


See preview on Cloudflare Pages: https://preview-232.quiltmc-org.pages.dev

UpcraftLP commented 4 months ago

Question : will this include the swagger JS on every page ? If so, how heavy is it ?

No, it will not. It will only load that on the /api page

Hex4dec commented 4 months ago

Anything blocking this? This has been drafted for a month.

ix0rai commented 4 months ago

if you check the preview, you'll see that this PR completely breaks i18n

Hex4dec commented 4 months ago

I see. How has such an issue not been fixed in a month's time? Surely it should take at most a week.

ix0rai commented 4 months ago

quilt is all volunteer work, so we can't expect our contributors to always promptly fix issues. one good thing about open source is that someone else can always pick up the work!

UpcraftLP commented 3 months ago

I see. How has such an issue not been fixed in a month's time? Surely it should take at most a week.

Surely it should also not be using an ancient version of astro and ancient versions of dependencies that break if you update, but here we are.

Feel free to check out the changes of this PR and fix the issues with it.

Southpaw1496 commented 2 months ago

The styling is a bit odd on dark mode, could that be changed?

Screenshot 2024-09-01 at 9 10 47 PM
Southpaw1496 commented 2 months ago

Ah, I see you've actually addressed the CSS in your original request

Question: The page on https://quiltmc.org/api/ is working fine for me, is there something I'm missing?

ix0rai commented 2 months ago

seems like the astro update may have fixed it!

Southpaw1496 commented 2 months ago

Well, brilliant!