Closed sciwhiz12 closed 2 years ago
Name | Link |
---|---|
Latest commit | 7c66125682ab0ecc635e0b41a58434007840d10e |
Latest deploy log | https://app.netlify.com/sites/ecstatic-booth-88897a/deploys/62def8e385f440000834de8b |
Deploy Preview | https://deploy-preview-56--ecstatic-booth-88897a.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
This looks good to me, thanks for that work. We'll just need to remember to stick with our basic layout!
This PR fixes #53 by implementing the solution I proposed in https://github.com/QuiltMC/quiltmc.org/issues/53#issuecomment-1194545380 to stick the footer at the bottom of the page at all times, even if the viewport is larger in height than the page height.
This leverages CSS grid to expand the main content to use the free space, and
min-height
[^1] to force the document body to fill the viewport at minimum, if the content doesn't stretch the page height enough to fill the viewport.This solution is currently reliant on the fact that there are three (viewable) elements underneath
<body>
: the header, the main content of the page, and the footer. Comments are added to aid in fixing this in the future if this fact changes (which probably won't).[^1]: Using
min-height: 100vh
on<body>
is better than the most often known solution ofheight: 100%
on<html>
and<body>
, as that old solution forces the height of the page to match exactly the height of the viewport.