search

QuiltServerTools / Wires

A server-side mod for simple server utilities
MIT License
4 stars 4 forks source link

Incompatible with MiniMOTD #4

Open jpenilla opened 2 years ago

jpenilla commented 2 years ago

Currently Wires and MiniMOTD both redirect the same method for handling server list MOTDs.

https://github.com/QuiltServerTools/Wires/blob/4965e639af4aa0ac751f303e47045de500bce750/src/main/java/net/quiltservertools/wires/mixins/MixinServerQueryNetworkHandler.java#L13

https://github.com/jpenilla/MiniMOTD/blob/80ae413c9d3ba4fecb31a2dfa0ddafb011c428d4/fabric/src/main/java/xyz/jpenilla/minimotd/fabric/mixin/ServerStatusPacketListenerImplMixin.java#L48

I'm not sure what the best course of action is here for compatibility, given we both need to modify the return value... Since this seems like a common mixin, maybe we should try and get something into Fabric API?

SmallSansSerif commented 2 years ago

Ah, is there a work around?

Just found this out today. https://pastebin.com/q9k7M9sV

otomir23 commented 2 years ago

Still no fix?

Tempest-5ky commented 2 years ago

Just leaving a comment here so i'll know when it's been fixed! I've been having the same issue argh