search

Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

Replace Page with SiteTree #29

Closed kinglozzer closed 6 years ago

kinglozzer commented 6 years ago

Because I’m awkward, none of my custom page types extend \Page, they all extend App\Model\Page. Switching to typehinting SilverStripe\CMS\Model\SiteTree allows both approaches 😁

codecov-io commented 6 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     33.63%   33.63%           
  Complexity      175      175           
=========================================
  Files            16       16           
  Lines           449      449           
=========================================
  Hits            151      151           
  Misses          298      298
Impacted Files Coverage Δ Complexity Δ
src/Extensions/PageHealthExtension.php 0% <ø> (ø) 7 <0> (ø) :arrow_down:
src/Forms/HealthAnalysisField.php 0% <0%> (ø) 8 <2> (ø) :arrow_down:
src/Analysis/Analysis.php 19.14% <100%> (ø) 18 <2> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d367865...c7599eb. Read the comment docs.

zanderwar commented 6 years ago

Great idea, thanks