search

Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

Handle file_get_contents() when it cannot retrieve text #30

Closed wilr closed 6 years ago

wilr commented 6 years ago

When a page cannot be viewed (say a database error) you instead get errors about the SEO file_get_contents call rather than the proper error message. This handles the case if file_get_contents returns nothing.

wilr commented 6 years ago

Related to #27

codecov-io commented 6 years ago

Codecov Report

Merging #30 into master will decrease coverage by 0.14%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
- Coverage     33.63%   33.48%   -0.15%     
- Complexity      175      176       +1     
============================================
  Files            16       16              
  Lines           449      451       +2     
============================================
  Hits            151      151              
- Misses          298      300       +2
Impacted Files Coverage Δ Complexity Δ
src/Extensions/PageHealthExtension.php 0% <0%> (ø) 8 <0> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d367865...a26b7ed. Read the comment docs.

zanderwar commented 6 years ago

Thanks!