search

Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

file_get_contents error #34

Closed Valandur closed 5 years ago

Valandur commented 5 years ago

SilverStripe: 4.1.2 silverstripe-seo: 1.0.1

I get the following error when trying to view a page:

[Warning] file_get_contents(): php_network_getaddresses: getaddrinfo failed: Name or service not known

This is probably due to the fact that my website is running on project.localhost, and that name cannot be resolved since I don't have a hosts entry (Chrome forwards *.localhost domains to the localhost, so I don't need a hosts entry).

I believe it would also not work if my website was protected by basic auth, such as on a staging/test server, since there is no way of passing credentials.

It would be nice if there was a way to disable the health analysis, or pass additional options such as headers.

zanderwar commented 5 years ago

Hey thanks for bringing this up

I'll eventually get around to seeing what I can do here for you and at the very least providing a way to disable health analysis via YML may be quite ideal.

What headers would you consider passing to the Health Analysis?

Valandur commented 5 years ago

Well for basic auth only the Authorization header is required, but I guess a more general approach to allow arbitrary headers would make sense, unless this conflicts with some internally used headers

zanderwar commented 5 years ago

This should be resolved in the latest release as file_get_contents is no longer used, can you give it a shot and let me know if you have any issues? I'll close this for now