search

Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

Render html using render() rather than file_get_contents etc #35

Closed gopalsareen closed 5 years ago

gopalsareen commented 6 years ago
  1. Render Html using render() rather than file_get_contents
  2. Config Yaml name added for the purpose of After/Before priority.
  3. Grid Field modified: field names added so that fields can be moved.
codecov-io commented 6 years ago

Codecov Report

Merging #35 into master will decrease coverage by 0.07%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #35      +/-   ##
===========================================
- Coverage     33.48%   33.4%   -0.08%     
  Complexity      176     176              
===========================================
  Files            16      16              
  Lines           451     452       +1     
===========================================
  Hits            151     151              
- Misses          300     301       +1
Impacted Files Coverage Δ Complexity Δ
src/Extensions/PageSeoExtension.php 50% <0%> (ø) 8 <0> (ø) :arrow_down:
src/Extensions/PageHealthExtension.php 0% <0%> (ø) 8 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 818d2c2...bbcc780. Read the comment docs.

wilr commented 5 years ago

ping @zanderwar?

zanderwar commented 5 years ago

Thank you for this, apologies for the delay