search

Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

Resolve issue #36 - php 7.3 compatiblity #37

Closed obj63mc closed 5 years ago

obj63mc commented 5 years ago

I have updated your dependency for php-simple-html-dom-parser with one that will work with PHP 7.3. Please refer to issue #36 and https://github.com/sunra/php-simple-html-dom-parser/issues/64#issuecomment-451073562

codecov-io commented 5 years ago

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage     33.48%   33.48%           
  Complexity      176      176           
=========================================
  Files            16       16           
  Lines           451      451           
=========================================
  Hits            151      151           
  Misses          300      300
Impacted Files Coverage Δ Complexity Δ
src/Forms/GoogleSearchPreview.php 0% <ø> (ø) 13 <0> (ø) :arrow_down:
src/Analysis/Analysis.php 19.14% <ø> (ø) 18 <0> (ø) :arrow_down:
src/Extensions/PageHealthExtension.php 0% <ø> (ø) 8 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 818d2c2...c481497. Read the comment docs.

zanderwar commented 5 years ago

Thanks for this @obj63mc, I see kub-at/php-simple-html-dom-parser is >=php5.3... that's great.

I'm going to go ahead and merge this in and release after some testing/fixes.