server with request limit causes internal server error

Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+

BSD 3-Clause "New" or "Revised" License

33 stars 20 forks source link

server with request limit causes internal server error #38

Closed guyvanbael closed 5 years ago

guyvanbael commented 5 years ago

when deploying to a server which has a limit on requests (to prevent infinite loops), i get an internal server error. file_get_contents(myUrl/?stage=Stage): failed to open stream: HTTP request failed! HTTP/1.0 429 Too Many Requests\r\n in myUrl/public_html/vendor/vulcandigital/silverstripe-seo/src/Extensions/PageHealthExtension.php

zanderwar commented 5 years ago

Hi @guyvanbael

I'm attempting to move this away entirely from making any HTTP requests at all, and instead using the built in renderer SilverStripe uses. I'm just lacking the time to do anything about it at the moment.

If I recall correctly however I do believe that this module only makes one single request when the preview loads, not dozens and definitely not enough to trigger rate limiting.