search

Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

not compatible with userforms 5.3.2 #40

Open guyvanbael opened 5 years ago

guyvanbael commented 5 years ago

using it in conjunction with userforms 5.3.2 (on ss4.3.3)

This is what's in the error log. Uncaught Exception BadMethodCallException: "Object->call(): the method 'Fields' does not exist on 'SilverStripe\CMS\Model\SiteTree'" at /Users/xxx/Documents/webroot/xxxx/vendor/silverstripe/framework/src/Core/CustomMethods.php line 54 {"exception":"[object] (BadMethodCallException(code: 0): Object->call(): the method 'Fields' does not exist on 'SilverStripe\CMS\Model\SiteTree' at /Users/xxx/Documents/webroot/xxx/vendor/silverstripe/framework/src/Core/CustomMethods.php:54)"} []

mooror commented 5 years ago

+1 I have also have encountered this issue, but this time with Userforms 5.4.0 and I can confirm that the error above is caused by this module as removing it (with composer remove vulcandigital/silverstripe-seo ) fixes the issue and allows the viewing of Userforms pages.

jinjie commented 5 years ago

Had the same issue too.

mooror commented 4 years ago

Was this issue ever fixed? I noticed that there is a commit labeled: Work around CMS crash on user-defined forms, does that commit have any effect on this issue?

guyvanbael commented 4 years ago

@mooror Since this issue is still open, i guess it isn't fixed yet

oddnoc commented 4 years ago

This was fixed as of version 1.0.6.

guyvanbael commented 2 years ago

@oddnoc i'm still experiencing this issue

oddnoc commented 2 years ago

@guyvanbael Can you provide details of your environment or a minimal example where this issue arises?

guyvanbael commented 2 years ago

@oddnoc using latest silverstripe (4.10), userforms 5.11.1. (and theres elemental-userforms as well 3.1.0). If i remove the silverstripe-seo module, the page is accessible again. Thanx for looking into it!

oddnoc commented 2 years ago

I'm unable to reproduce this issue. Can you provide your composer.json?

guyvanbael commented 2 years ago

Here's the composer.json. Mind that i've swapped out the module for the toastnz's opengraph module because this site is already live. { "name": "silverstripe/installer", "type": "silverstripe-recipe", "description": "The SilverStripe Framework Installer", "require": { "php": "^7.3 || ^8.0", "silverstripe/recipe-plugin": "^1.2", "silverstripe/recipe-cms": "~4.10.0@stable", "silverstripe-themes/simple": "~3.2.0", "silverstripe/login-forms": "~4.6.0@stable", "axllent/silverstripe-email-obfuscator": "^2.0", "wilr/silverstripe-googlesitemaps": "^2.2", "symbiote/silverstripe-gridfieldextensions": "^3.3", "dnadesign/silverstripe-elemental": "^4.8", "colymba/gridfield-bulk-editing-tools": "^3.0", "silverstripe/userforms": "^5.11", "nswdpc/silverstripe-recaptcha-v3": "^0.1.2", "nswdpc/silverstripe-recaptcha-v3-userforms": "^0.1.1", "dnadesign/silverstripe-elemental-userforms": "^3.1", "toastnz/open-graph-meta": "^2.0" }, "require-dev": { "phpunit/phpunit": "^9.5" }, "extra": { "resources-dir": "_resources", "project-files-installed": [ "app/.htaccess", "app/_config.php", "app/_config/mimevalidator.yml", "app/_config/mysite.yml", "app/src/Page.php", "app/src/PageController.php" ], "public-files-installed": [ ".htaccess", "index.php", "web.config" ], "expose": [ "themes/otto/dist" ] }, "config": { "process-timeout": 600, "allow-plugins": { "composer/installers": true, "silverstripe/vendor-plugin": true, "silverstripe/recipe-plugin": true } }, "prefer-stable": true, "minimum-stability": "dev" }