Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

A problem with this module is causing CSS styling issues in the CMS Pages interface #47

Closed mooror closed 4 years ago

mooror commented 4 years ago

The Problem

A problem with this module is causing the debug.css file to used on the CMS Pages (edit) interface which in turn causes styling issues

Steps to reproduce

  1. Login to the CMS (admin/)
  2. Travel to the Pages section using the left hand navigation (admin/pages/)
  3. Click on one of your pages in the Sitetree to edit it (admin/pages/edit/show/1)
  4. Look closely at the styles of the CMS interface

Screenshots

Before Installation

Here is how the CMS Pages edit interface should look (in SS4) firefox-cms-pages-edit-styles-normal

After Installation

And here is what it currently looks like (some styling issues are highlighted in yellow). The most noticeable difference is the font size and the left hand menu (which has items jutting out) firefox-cms-pages-edit-styles-bug

The Stylesheet causing the issue

You can see that the debug.css file is being included. If you disable its styles using the developer tools the styling issues will be fixed. firefox-console-debug-css

Possible Explanation

I originally brought this problem up over in the Silverstripe Slack channel (see this conversation) because I thought that it may be a framework bug (because debug.css is from the silverstripe framework). However when I discussed this issue with Andy he explained to me that this stylesheet is only included when the debug class (SilverStripe\Dev\Debug) is included or when an error has occurred.

oddnoc commented 4 years ago

This is fixed in version 1.0.7