search

Quinn-Interactive / silverstripe-seo

An all-in-one SEO module for SilverStripe 4.1+
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

REFACTOR use MetaComponents() method allowing for better extensibility #64

Open muskie9 opened 3 years ago

muskie9 commented 3 years ago

resolves #59

This is a fairly major change to how the tags are built. I've updated the existing tests to match using the MetaComponents() method and things appear to be generating as expected.

One thing I did not take into account with this update is if there is a desire for additional logic surrounding the handling of the canonical tag for things like Virtual Page, or if a canonical already exists from some other extension. If this module's extension is loaded last, it will simply overwrite any canonical in the MetaComponents. That being said, any module using the MetaTags() method, and setting a canonical could result in two canonical tags being generated.

Open to feedback on any/all of this and am happy to update where needed.

oddnoc commented 2 years ago

Could you rebase your branch on develop? Thanks!

sunnysideup commented 1 year ago

could this be actioned @oddnoc ?