QuinnDamerell / Baconit

A beatiful, powerful, reddit client for Windows 10.
https://www.reddit.com/r/BaconitDev/
GNU General Public License v2.0
242 stars 81 forks source link

Fix for issue #57 #60

Open Conrad2134 opened 8 years ago

Conrad2134 commented 8 years ago

This fixes issue #57 Can't filter for "Hot". The issue was basically that, when navigating to a subreddit, the id getting passed into the .Navigate(...) method was always "funnyHotWeek" (assuming you're navigating to /r/funny). If you had switched the default sort type in your settings (to "new" in this case), the panel would behave as if it was "funnyNewWeek". When you would then go to change the sort to "hot", the .Navigate(...) method would think that you're trying to go from "funnyHotWeek" to "funnyHotWeek" and it would basically do nothing, if that makes sense.

There might be a cleaner way to do it. There's probably not really a need to pass in the sort arguments in both of those places that were changed, since they would end up as the default anyway, so I can always reverse that if need be.

I merged master into the develop branch. I can always reverse that merge to separate just my changes if that works better.

Let me know! Thanks!