QuinnDamerell / Baconit

A beatiful, powerful, reddit client for Windows 10.
https://www.reddit.com/r/BaconitDev/
GNU General Public License v2.0
242 stars 81 forks source link

Set image source after setting decode size to fix #71 #77

Open dreamlayers opened 8 years ago

dreamlayers commented 8 years ago

Images were decoding at full size despite setting decode size. This seems to be because the source was set first, so the image could decode before decode size was set.

It seems the intent was to initially display images scaled to fit, but images were decoding at full size because the source was set before the decode sizes. In Microsoft's example, the source is set after, and setting the source after fixes the problem. There may have been a race condition here, because images were sometimes displayed scaled to fit initially.

With this change the behaviour is:

Images always load scaled to fit initially. Control + mouse wheel up goes to a 1:1 view where I can zoom in and out smoothly via Control + mouse wheel. If I zoom out until the image fits, it goes back to the initial state.

get-fooby commented 7 years ago

Has this made it into the store release? there is still chatter about this on the baconit subreddit...

farid-fari commented 6 years ago

1 year later, it'd be cool if this were implemented...

I think I'll have to selfbuild and sideload