search

Quintor / StudyBits

Apache License 2.0
6 stars 5 forks source link

Streamline attributes in createCredential and fulfillProofRequest #97

Closed PJUllrich closed 5 years ago

PJUllrich commented 6 years ago

The function createCredential in Issuer has a Map<String, Object> as second parameter. The function fulfillProofRequest in Prover has a Map<String, String> as parameter.

In the Main function, this causes me some issue with handing in the attributes into fulfillProofRequest that I've used previously to create the Claim. Do you think that these two should maybe be made equal to e.g. Map<String, Object>?

PJUllrich commented 6 years ago

Not feasible since the wrapper functions need the Maps as input parameters.

pimotte commented 6 years ago

I'd say we want this, but we actually need to refactor the wrapper to support both datatypes, currently the proving supports only Strings for a reason I forgot. So I'll reopen this and mark this as "wrapper"

pimotte commented 5 years ago

Moved to https://github.com/Quintor/quindy/issues/30