Closed skyfroger closed 2 years ago
Thanks. Looks good.
I haven't put in translation support for worlds description, worlds editor, or the robot configurator yet, so no way to translate that for now.
Didn't realize the issue with btoa and unicode. Would...
'data:text/plain;charset=UTF-8,' + encodeURIComponent(blockly.getXmlText())
...be better than...
'data:application/xml;base64,' + btoa(unescape(encodeURIComponent(blockly.getXmlText())));;
? In my limited test, it both works fine, but it seems that unescape is no longer recommended for use.
Thanks for approvin my PR. I will test your solution to unicode problem, while continuing translation process.
Not every string translated right now. I will continue translating info and warning messages and tooltips text. Also I am not certain, how to translate Worlds description and Worlds editor interface.