QuirkyCort / gears

Generic Educational Robotics Simulator
Other
65 stars 41 forks source link

Android: Robot Configurator not working #73

Closed germanicianus closed 3 years ago

germanicianus commented 3 years ago

The controls are shown, but the rest of the screen stays white. Tested on an Amazon Fire TV 4K with the latest update and on an Android phone. On an iPhone 7 Plus with latest iOS it works - despite some layout problems.

QuirkyCort commented 3 years ago

Can't tell what's the problem from that, but it may be because of the virtual joystick; it tries to set it up in the configurator, and throws an error because it is not present. It doesn't seem to cause a problem when tested on my browser, but different browsers may handle these errors a little differently.

I've put in a fix. See if it works now.

germanicianus commented 3 years ago

@QuirkyCort, it works now. It would be very helpful when you reference the issue(s) in the correspondent commits for tracking. Then the commits would be listed within the issues automatically. There is a nice post on stackoverflow and some examples can be seen in https://github.com/plone/buildout.coredev/issues/67.

For the record - this issue is fixed by https://github.com/QuirkyCort/gears/commit/abbaa16191134e99e078f07f96cf6adbb4e9f288.