search

QuirkyCort / gears

Generic Educational Robotics Simulator
Other
65 stars 41 forks source link

Unable to upload zip files to Arena #81

Closed sgmurray closed 3 years ago

sgmurray commented 3 years ago

Uploading a zip file and clicking the checkbox in Arena mode bots tab gives an error.

Screenshot from 2021-05-05 00-43-56

QuirkyCort commented 3 years ago

It's a race condition. Sometimes the render function will run before the robot is fully loaded.

I've put in some additional checks to prevent this. Should be ok now.

sgmurray commented 3 years ago

I am still able to trigger the race condition.

self.leftWheel != null seems to work better than typeof self.leftWheel != 'undefined' in Robot.js

QuirkyCort commented 3 years ago

You're right. self.leftWheel is always defined, so I should be checking for null instead. I've fixed it.

Strangely enough, I couldn't trigger the problem after adding the type check. Probably just a coincidence...