search

QuisApp / flutter_contacts

MIT License
88 stars 143 forks source link

json_serializable dev dependency is redundant #6

Closed ycherniavskyi closed 3 years ago

ycherniavskyi commented 3 years ago

It seems that json_serializable dev dependency, which points to add in the first step of installation, is redundant.

I just didn't add it and everything compiled without any issue on Android and iOS.

joachimvalente commented 3 years ago

Thanks a lot for flagging! I'm about to release a new version that doesn't depend on json_serializable / build_runner at all anyway, and I'll update the docs.

ycherniavskyi commented 3 years ago

It sounds great.

But I am curious, do you have some issue with json_serializable so that you decided to get rid of it?

joachimvalente commented 3 years ago

I initially used it to avoid boilerplate, but there are a lot of things it doesn't do, like toString(), operator==, hashCode, and types Uint8List and a few other things for which you need custom logic anyway.