Based on these, I wonder whether the following should be considered:
have a DimensionVector type, and likewise a StabilityParameter type? the latter would also work with things more general than integers, we should at least allow rational numbers? it's a though one, because in Sage I would argue against it, but maybe in Julia it makes sense, as there's so little overhead?
why Teleman_bound_onstratum and not Teleman_bound_on_stratum?
there are spurious / missing new lines everywhere: this should be more consistent
it should be n_vertices (and be an alias for number_of_vertices)
Related to this I have the following questions about the structure of the code:
maybe Chow-related things should be put in chow.jl, given how hard it is to navigate moduli.jl given its size
for clarity, shouldn't there be a quiver.jl file with things that are currently in QuiverTools.jl and QuiverTools-types.jl?
There might be more to come as I ponder these questions a bit more.
We are aware of the Julia style guide and (largely) follow it, but it's probably a good idea to take a look at the OSCAR style guide.
Based on these, I wonder whether the following should be considered:
DimensionVectortype, and likewise aStabilityParametertype? the latter would also work with things more general than integers, we should at least allow rational numbers? it's a though one, because in Sage I would argue against it, but maybe in Julia it makes sense, as there's so little overhead?Teleman_bound_onstratumand notTeleman_bound_on_stratum?n_vertices(and be an alias fornumber_of_vertices)Related to this I have the following questions about the structure of the code:
chow.jl, given how hard it is to navigatemoduli.jlgiven its sizequiver.jlfile with things that are currently inQuiverTools.jlandQuiverTools-types.jl?There might be more to come as I ponder these questions a bit more.