search

Quivr / Android-Week-View

Android Week View is an android library to display calendars (week view or day view) within the app. It supports custom styling.
Apache License 2.0
258 stars 64 forks source link

Updated to be compatible with Android 26 or higher without need of java.util.Calendar #110

Closed jlurena closed 6 years ago

jlurena commented 6 years ago

NOTE I do not want to merge into Develop (if its the main branch). I would just like a branch that can be driven by the community for Applications that only support Android 26 or higher, without the need of Support Libraries etc.

AndroidDeveloperLB commented 6 years ago

Really wish you had tried to work on my fork instead, as I've converted it to Kotlin, fixed a lot of issues, and added a few more features: https://github.com/AndroidDeveloperLB/Android-Week-View

But according to what I see on your changes, you've raised the minSdk quite a lot. API 26 is only available to 5.7% of users out there, according to Android dashboard website: https://developer.android.com/about/dashboards/

I would suggest other types of optimizations instead. One of them is to try to reduce number of instance creations of all classes upon drawing of the View, especially instances of Calendar class.