search

Quivr / Android-Week-View

Android Week View is an android library to display calendars (week view or day view) within the app. It supports custom styling.
Apache License 2.0
257 stars 64 forks source link

Use String as Event Id #44

Closed reilem closed 6 years ago

reilem commented 7 years ago

Use String instead of int for Event ids. This will ease communication when fetching Custom Calendar events from device.

ShivamDev31 commented 7 years ago

Just change the id in WeekView class and respective places.

jhoobergs commented 7 years ago

I think lines like https://github.com/Quivr/Android-Week-View/blob/develop/library/src/main/java/com/alamkanak/weekview/WeekView.java#L141 will break it then. The easiest thing might be to create a class 'WeekViewId' which has a single property id and people can then also override that class together with the WeekView class.

ShivamDev31 commented 7 years ago

Ofcourse we have to change it at all the places. In the attributes too. I'm using String instead of long by replacing it all the required places.

jhoobergs commented 7 years ago

Yes, but you use your own fork probably ? I would update it so people don't need to fork the repo but can just adapt it themselves by override some classes.

udaysrinath commented 6 years ago

Just following up on this @jhoobergs , you mentioned you are going to update it, do you have a proposed solution merged already?

udaysrinath commented 6 years ago

Any update on this front @jhoobergs ? Did you get a chance to get the changes for this?

jhoobergs commented 6 years ago

@udaysrinath I probably won't have time to do it myself in the next month. If you want to fix it yourself, just create a PR and I will find the time to review it.

udaysrinath commented 6 years ago

@jhoobergs Opened a PR for this, can you please review?