search

Quivr / Android-Week-View

Android Week View is an android library to display calendars (week view or day view) within the app. It supports custom styling.
Apache License 2.0
257 stars 64 forks source link

Scroll NumberOfVisibleDays by NumberOfVisibleDays (inspired by #68) #88

Open Quachero opened 6 years ago

Quachero commented 6 years ago

This feature enable the scroll by the amount of days setted in NumberOfVisibleDays.

It's inspired by the work of SkyleKayma (pullrequest : #68) with some changes like the possibility to enable or not the scroll by the amount of days setted in NumberOfVisibleDays, ... and it's adapted to the last version of Week View library.

SkyleKayma commented 6 years ago

Glad to see that someone took the time to set up this feature ! (I said I'll do it and I did not do it.) My word is worthless now :'( I hope this will be accepted one day ! I believe it !

AndroidDeveloperLB commented 6 years ago

@Quachero How can I clone this pull request? I tried to clone your repository, but it doesn't seem to contain the code presented here , meaning "isScrollNumberVisibleDays" isn't present...

AndroidDeveloperLB commented 6 years ago

@Quachero Anyway, after manually getting the files, I've found a bug in this code: https://github.com/Quivr/Android-Week-View/issues/31#issuecomment-387005542

AndroidDeveloperLB commented 6 years ago

I've prepared a pull request that contains those changes, together with some fixes of issues I've found, and conversion to 100% Kotlin code : https://github.com/Quachero/Android-Week-View/pull/1

Sadly, some issues that I've found still exist: