Qulacs-Osaka / qulacs-osaka

Development branch of qulacs at Osaka Univ
MIT License
13 stars 6 forks source link

Fetch untracked pull requests in Qulacs #351

Closed kodack64 closed 2 years ago

kodack64 commented 2 years ago

For merging qulacs-osaka to qulacs, I've merged the three following pull requests that are applied only to qulacs.

276: https://github.com/qulacs/qulacs/pull/276 I've added several tests on evaluating expectation values that are dropped in the current dev. I have modified several tests since qulacs-osaka will raise exceptions.

293: https://github.com/qulacs/qulacs/pull/293 I've fixed the problem that the copy of composition gates incurred memory leak.

300: https://github.com/qulacs/qulacs/pull/300 Bugfix for tensor product for density matrix with different size outputs wrong results.

Updates:6/22 Two more PRs are added

306: https://github.com/qulacs/qulacs/pull/306 Memory leak in creating operators from openfermion files

315: https://github.com/qulacs/qulacs/pull/315 Bugs in calculating odd-Pauli-Y observables for density matrices

codecov-commenter commented 2 years ago

Codecov Report

Merging #351 (cd930ba) into dev (93648f0) will increase coverage by 0.16%. The diff coverage is 69.56%.

@@            Coverage Diff             @@
##              dev     #351      +/-   ##
==========================================
+ Coverage   71.00%   71.17%   +0.16%     
==========================================
  Files          84       84              
  Lines        5971     5977       +6     
==========================================
+ Hits         4240     4254      +14     
+ Misses       1731     1723       -8     
Impacted Files Coverage Δ
src/cppsim/utility.hpp 100.00% <ø> (ø)
src/csim/stat_ops_dm.cpp 33.02% <0.00%> (ø)
src/cppsim/gate_general.hpp 56.09% <28.57%> (+0.32%) :arrow_up:
src/cppsim/pauli_operator.cpp 71.27% <100.00%> (+1.11%) :arrow_up:
src/cppsim/pauli_operator.hpp 95.00% <100.00%> (+1.25%) :arrow_up:
src/csim/stat_ops_expectation_value.cpp 88.60% <0.00%> (-7.60%) :arrow_down:
src/csim/update_ops_pauli_multi.cpp 65.00% <0.00%> (+0.62%) :arrow_up:
src/cppsim/exception.hpp 15.00% <0.00%> (+5.00%) :arrow_up:
src/csim/update_ops_matrix_dense_single.cpp 98.87% <0.00%> (+10.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93648f0...cd930ba. Read the comment docs.

forest1040 commented 2 years ago

LGTMです!