Qulacs-Osaka / scikit-qulacs

scikit-qulacs is a library for quantum neural network. This library is based on qulacs and named after scikit-learn.
https://qulacs-osaka.github.io/scikit-qulacs/index.html
MIT License
19 stars 6 forks source link

Fix impl that should have been done in #195 #205

Closed ikanago closed 2 years ago

ikanago commented 2 years ago

backprop_inner_product が #195 の変更に対応できていなかったので修正しました.

codecov[bot] commented 2 years ago

Codecov Report

Merging #205 (25e9687) into main (a578826) will increase coverage by 0.84%. The diff coverage is 97.00%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   89.88%   90.73%   +0.84%     
==========================================
  Files          11       12       +1     
  Lines         771      874     +103     
  Branches      149      164      +15     
==========================================
+ Hits          693      793     +100     
- Misses         49       50       +1     
- Partials       29       31       +2     
Impacted Files Coverage Δ
skqulacs/circuit/circuit.py 83.33% <88.88%> (+0.61%) :arrow_up:
skqulacs/qnn/generation.py 97.77% <97.77%> (ø)
skqulacs/qnn/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b91ae8e...25e9687. Read the comment docs.

forest1040 commented 2 years ago

@ikanago @WATLE すみません!ありがとうございます!

forest1040 commented 2 years ago

マージしました。