search

QuocAnhJ / node_mongo_boilerplate

2 stars 4 forks source link

Request validation should be separated as a middleware to avoid Violating Single responsibility principle #3

Closed pmnhatdn closed 6 years ago

pmnhatdn commented 6 years ago

` const addBooks = async (req, res) => { try { / Field validation / req.checkBody('title', 'Title cannot be blank').notEmpty().trim(); req.checkBody('author', 'Author cannot be blank').notEmpty().trim(); req.checkBody('genre').trim(); req.checkBody('read', 'Read is must boolean type').isBoolean().trim();

` Field Validation should be in a separated middleware.

router.post('/books', BookCreationValidatorMiddleware, addBooks);

QuocAnhJ commented 6 years ago

Fixed