search

QuokkaStake / cosmos-validators-exporter

A Prometheus exporter to fetch data about your validators in Cosmos-based blockchains.
GNU General Public License v3.0
12 stars 14 forks source link

chore: add utils and types test #61

Closed freak12techno closed 4 months ago

freak12techno commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

[!WARNING]

Review failed

The head commit changed during the review from 2f0797b205f9c391d1f54f6822e7244308fc4d09 to 6938d5b407c2442c6c9db335a90f95ca370cd72f.

Walkthrough

This update encompasses various enhancements and refactorings across multiple packages, including adding comprehensive test functions, altering error handling in logging, and refining configuration behaviors. Key changes include the introduction of new tests for HTTP predicates, validator and response amount structs, utility functions, and tracing operations. Logging error handling has been updated to use log.Panic() instead of log.Fatal(), and configuration warnings are now collected and logged more systematically.

Changes

File(s) Change Summary
pkg/types/http_predicate_test.go Added test functions for HTTP predicate logic related to block height in responses.
pkg/types/tendermint_test.go Introduced tests for Validator and ResponseAmount structs.
pkg/utils/utils_test.go Added tests for utility functions like comparing Bech32 addresses, converting types, and filtering arrays.
pkg/logger/logger.go Updated logging to use log.Panic() instead of log.Fatal() when parsing log level fails.
pkg/logger/logger_test.go Introduced tests for logging functionality.
pkg/config/query_test.go Added test function for the Enabled method in Queries data structure.
pkg/config/chain.go Modified DisplayWarnings method to return a slice of Warning structs.
pkg/config/config.go Updated DisplayWarnings to handle warnings from each chain individually.
pkg/config/denom_info.go Modified DisplayWarnings method to return warning slices.
pkg/config/display_warning.go Added Warning struct in the config package.
pkg/... Added various test functions for Chain, DenomInfo, Tracing, and Validator configurations.
pkg/tracing/provider.go Simplified NewTraceProvider by eliminating error handling for resource merging.
pkg/tracing/tracer.go Introduced InitNoopTracer function.
pkg/tracing/tracer_test.go Added test functions for exporters and tracers based on configuration.
cmd/cosmos-validators-exporter.go Refactored warning display logic to log each warning message and its labels individually.
pkg/app.go Refactored logic for displaying warnings from appConfig.

Poem

In code's domain, where logic we weave,
Tests now stand guard, never to leave.
Parsing errors no longer in dread,
Panic replaces abrupt logs of dead.
Configs now whisper their warnings clear,
Ensuring our paths are free of fear.
Onward we code, with changes in stride,
With each small step, more quality inside. 🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 74.02597% with 20 lines in your changes missing coverage. Please review.

Project coverage is 13.38%. Comparing base (cce5388) to head (6938d5b).

Files Patch % Lines
cmd/cosmos-validators-exporter.go 0.00% 12 Missing :warning:
pkg/app.go 0.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== + Coverage 1.56% 13.38% +11.81% ========================================== Files 57 59 +2 Lines 2230 2272 +42 ========================================== + Hits 35 304 +269 + Misses 2195 1967 -228 - Partials 0 1 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

freak12techno commented 4 months ago

@coderabbitai review

coderabbitai[bot] commented 4 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.