coderabbitai[bot]
commented
3 months ago [!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...
Commits
Files that changed from the base of the PR and between 1556700772b6e01f9d31999a69d94176aa27a210 and c6a300f23fcf66e9f58c7cfed9dbee3d4d6ff076.Files ignored due to path filters (1)
* `go.sum` is excluded by `!**/*.sum`Files selected for processing (9)
* assets/coingecko.json (1 hunks) * config.example.toml (2 hunks) * go.mod (1 hunks) * pkg/app.go (3 hunks) * pkg/fetchers/price.go (3 hunks) * pkg/fetchers/price_test.go (1 hunks) * pkg/http/http.go (1 hunks) * pkg/http/http_test.go (1 hunks) * pkg/tendermint/rpc.go (3 hunks)_________________________________________________________________ < I am below the bugs. I am above the bugs. I am around the bugs. > ----------------------------------------------------------------- \ \ (\__/) (•ㅅ•) / づ
Walkthrough
Recent updates have expanded the codebase to include various JSON files containing blockchain data, like balances, rewards, and delegations. Additionally, new functions and test cases were added to handle these data structures and interactions. The primary change is the switch from using a single Config object to multiple Chain objects across several components to enhance flexibility. This shift impacts functionality and interaction patterns, requiring updated initializations and access patterns in affected modules.
Changes
| Files/Directories | Change Summary |
|---|---|
| assets/balances.json, assets/error.json etc. | Added JSON files for blockchain data like balances, rewards, commissions, delegations, node info, etc. |
| assets/fs.go | Introduced GetBytesOrPanic function to handle file bytes retrieval and panics on errors. |
| assets/fs_test.go | Added test function TestGetPanicOrFailPanic to test the panic behavior of the new function. |
| pkg/app.go | Updated NewApp function to pass appConfig.Chains to NewBalanceFetcher. |
| .../balance.go, .../balance_test.go | Switched from single Config object to array of Chain objects in BalanceFetcher and its tests. |
| .../commission.go, .../commission_test.go | Updated CommissionFetcher to use a list of Chain objects, including modifications in tests. |
| .../consumer_info.go, .../consumer_validators.go | Changed ConsumerInfoFetcher and ConsumerValidatorsFetcher to use arrays for chains. |
| .../node_info.go | Modified NodeInfoFetcher to handle multiple Chain objects instead of a single Config. |
| .../rewards.go, .../rewards_test.go | Altered RewardsFetcher to iterate over chains, and added corresponding tests. |
| .../self_delegation.go | Updated SelfDelegationFetcher to use multiple chains, reflected in structural changes. |
| .../logger/logger.go, .../logger/logger_test.go | Added GetNopLogger for NOP logger, with accompanying tests to validate functionality. |
| .../generators/..._test.go | Updated loggers in test generators to use GetNopLogger instead of GetDefaultLogger. |
| .../signing_info.go, .../signing_info_test.go | Modified SigningInfoFetcher to handle multiple chains, including extensive test cases. |
| .../delegations_test.go | Introduced comprehensive tests for fetching delegations data. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant App
participant BalanceFetcher
participant Chain
User->>App: Start Application
App->>BalanceFetcher: Initialize with Chains
BalanceFetcher->>Chain: Fetch Balance for each chain
Chain-->>BalanceFetcher: Return Balance Data
BalanceFetcher-->>App: Aggregated Balance Data
App-->>User: Display BalancesPoem
In files of JSON, our balances sing,
Fetchers arise with the chains they bring.
Commission and rewards within the code,
Flexibility in chains, a new road.
Loggers now quiet, tests complete,
Each module's task performed so neat.
Blockchain whispers, coders cheer,
A rabbit’s code, crystal clear! 🐰
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
Summary by CodeRabbit
New Features
Tests
Refactor