Closed freak12techno closed 4 months ago
The changes involve refactoring the NewQueriesMetrics
function to accept a list of chain configurations instead of a single application config object, affecting multiple files accordingly. New test cases are also introduced for validating the QuerierMetrics
functionality, ensuring metric generation based on the updated chain configurations.
File | Summary |
---|---|
pkg/app.go |
Updated NewQueriesMetrics function call to pass chains instead of config. |
pkg/querier_metrics_test.go |
Introduced test cases for QuerierMetrics functionality. |
pkg/queries_metrics.go |
Updated QueriesMetrics struct and methods to use chains instead of config. |
sequenceDiagram
participant App
participant QueriesMetrics
participant Chain
App->>QueriesMetrics: NewQueriesMetrics(chains, queryInfos)
QueriesMetrics->>QueriesMetrics: Initialize with chains and queryInfos
loop For each chain
QueriesMetrics->>Chain: GetMetrics()
Chain-->>QueriesMetrics: Return Metrics
end
QueriesMetrics-->>App: Return Aggregate Metrics
In the land of code, where changes flow, The metrics dance, and numbers grow. Chains together, data sings, Querier Metrics spread their wings. Tests arise to guard the gate, Ensuring code's unyielding fate. Another day in code complete, Our structs and chains now fleet.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 75.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 93.51%. Comparing base (
560faca
) to head (ee451a9
).
Files | Patch % | Lines |
---|---|---|
pkg/app.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary by CodeRabbit
Bug Fixes
Tests
QuerierMetrics
to ensure the correct generation of metrics for various chains and queries.These changes ensure more precise metric tracking and better test coverage for the application's query performance.