search

QuokkaStake / cosmos-validators-exporter

A Prometheus exporter to fetch data about your validators in Cosmos-based blockchains.
GNU General Public License v3.0
12 stars 14 forks source link

feat: removed soft opt-out metrics #81

Closed freak12techno closed 1 month ago

freak12techno commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request introduces significant changes across several files, primarily focusing on the removal of components related to soft opt-out thresholds. This includes the elimination of fetchers, generators, constants, and associated tests, indicating a shift in the application's architecture. The NewApp function in pkg/app.go has been modified to remove initializations for the soft opt-out threshold components, which may affect related functionalities throughout the application.

Changes

File Path Change Summary
pkg/app.go Removed initializations for NewSoftOptOutThresholdFetcher and NewSoftOptOutThresholdGenerator.
pkg/constants/constants.go Removed constants FetcherNameSoftOptOutThreshold and FetcherNameCommission, reorganized remaining constants.
pkg/fetchers/soft_opt_out_threshold.go Deleted the entire file containing the SoftOptOutThresholdFetcher implementation.
pkg/fetchers/soft_opt_out_threshold_test.go Deleted the entire file containing unit tests for the SoftOptOutThresholdFetcher.
pkg/generators/soft_opt_out_threshold.go Deleted the entire file containing the SoftOptOutThresholdGenerator implementation.
pkg/generators/soft_opt_out_threshold_test.go Deleted the entire file containing unit tests for the SoftOptOutThresholdGenerator.
pkg/tendermint/rpc.go Removed the GetConsumerSoftOutOutThreshold function from the RPC struct.

Possibly related PRs

🐰 In fields of code, we leap and bound,
Removing fetchers, new paths are found.
Constants and tests, all gone in a flash,
A cleaner design, a swift, silent dash.
With every change, the app grows bright,
Hop along, dear code, into the light! 🌟

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between bae771deeaa3bf082fa92cf4cb1cf621834ebb22 and b3228b424a53feaa12ecca50bf75210f483f12cf.
Files selected for processing (7) * pkg/app.go (0 hunks) * pkg/constants/constants.go (1 hunks) * pkg/fetchers/soft_opt_out_threshold.go (0 hunks) * pkg/fetchers/soft_opt_out_threshold_test.go (0 hunks) * pkg/generators/soft_opt_out_threshold.go (0 hunks) * pkg/generators/soft_opt_out_threshold_test.go (0 hunks) * pkg/tendermint/rpc.go (0 hunks)
Files not reviewed due to no reviewable changes (6) * pkg/app.go * pkg/fetchers/soft_opt_out_threshold.go * pkg/fetchers/soft_opt_out_threshold_test.go * pkg/generators/soft_opt_out_threshold.go * pkg/generators/soft_opt_out_threshold_test.go * pkg/tendermint/rpc.go
Files skipped from review due to trivial changes (1) * pkg/constants/constants.go
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bae771d) to head (b3228b4). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 67 65 -2 Lines 2793 2712 -81 ========================================= - Hits 2793 2712 -81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.