[TabManager]: Switching Tab-Manager side by side produces clutter on mate DE

[JHooverman]

System Information Application version: 1.7.0 (7e7bdf61df) Qt version: 5.3.2 WebKit version: 538.1 Build time: Jul 12 2014 17:19:13 Platform: openSUSE Tumbleweed (Linux)

Step-by-step procedure (1) Start QupZilla (2) Open some tabs (3) Click on Tab-Manager icon in the statusbar (4) Tab-Manager is opened in a window on the right of the screen (5) Toggle window/ sidebar view, icon on the right

(6) A new Tab-Manager window is opened on the left of the screen. Expected behaviour: The sidebar should open.

(7) The initial Tab-Manager window from step (4) freezes

(8) When I close the Tab-Manager from step (4) (clicking x), QupZilla shuts down immediately, no crash though.

[srazi]

Would you please test it with debug build and when qupzilla is running through gdb?

EDIT: About (5) that button just reorder qupzilla window and tabmanager window side by side like this:

[JHooverman]

Yes, I will try this tomorrow and paste the result on gist.

[JHooverman]

After some checks I found out, that the initial Tab-Manager window on the right, which looks some sort of grey, is not an existing Tab-Manager window. It is more like "burned" in the desktop. So, if I click on the "x", it is not the one of the Tab-Manager, but the one of QupZilla. This is why I do not get any valuable output in the gdb-session - it is a normal quit. It seems, that my DE (mate) does not like the windows arranging of the Tab-Manager as you can see in this screenshot:

The empty space on the right was the location, where the Tab-Manager was placed. I am not able to resize QupZilla. In enlightenment for example, Tab-Manager works as expected.

So, I am closing this issue, since it is not related to the Tab-Manager.

[srazi]

@JHooverman: Please test this patch:

diff --git a/plugins/TabManager/tabmanagerwidgetcontroller.cpp b/plugins/TabManager/tabmanagerwidgetcontroller.cpp
index b8fbcfa..2d24675 100644
--- a/plugins/TabManager/tabmanagerwidgetcontroller.cpp
+++ b/plugins/TabManager/tabmanagerwidgetcontroller.cpp
@@ -220,12 +220,18 @@ void TabManagerWidgetController::showSideBySide()
     QRect qupzillaRect(managerRect.topRight().x() + 2 * frameWidth, managerRect.top(),
                        availableGeometry.width() - managerRect.width() - 4 * frameWidth, managerRect.height());

-    defaultTabManager()->setGeometry(managerRect);
-    mApp->getWindow()->setGeometry(qupzillaRect);
-    mApp->getWindow()->showNormal();
-    mApp->getWindow()->raise();
+    BrowserWindow* window = mApp->getWindow();
+    window->setUpdatesEnabled(false);
+    defaultTabManager()->setUpdatesEnabled(false);
+
+    window->setGeometry(qupzillaRect);
+    window->showNormal();
+    window->raise();

+    defaultTabManager()->setGeometry(managerRect);
     defaultTabManager()->show();
-    defaultTabManager()->activateWindow();
     defaultTabManager()->raise();
+
+    defaultTabManager()->setUpdatesEnabled(true);
+    window->setUpdatesEnabled(true);
 }

[JHooverman]

No, this does mit fix it for me. As you can see in this screeshot it looks as QupZilla was cloned. You see two statusbars. That's really weird.

[JHooverman]

I would like to add, that it works with Gnome3 desktop as well.