search

QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.12k stars 348 forks source link

Feature Request: Zoom in when pressing Ctrl+= #2400

Open ghost opened 7 years ago

ghost commented 7 years ago

[Ctrl]+[+] does make it zoom in, but the [Shift] button still has to be pressed. I think it would be better if Zoom In works by pressing [Ctrl]+[=].

Martii commented 7 years ago

Platform and QupZilla version please.

Zooms in with Linux/KDE and Ctrl + + without any further modifiers.

Test image:

ghost commented 7 years ago

QupZilla 2.1.99 (3c60b8417a) on Linux. Zooms in without needing to press Shift? I'm using a standard keyboard where to access the + key the Shift has to be pressed.

Martii commented 7 years ago

Ahh I see what you mean... not the numeric keypad... thought it wasn't zooming/unzooming for you at all. Confirmed as needing it on the top row of a standard keyboard.

elcste commented 7 years ago

This used to work, e.g. it works with the 2.1.2 (5.8) AppImage.

Chiitoo commented 7 years ago

What is 'standard' for one, might not be a 'standard' for another. :]

That is to say, with the layout I generally use, I make the plus (+) sign without shift, and as such, zooming is triggered by 'ctrl_+'.

From a quick look-see, Firefox for example behaves the same.

Perhaps the key(s) should be customisable?

Martii commented 7 years ago

It would appear from a read of the classes utilized at http://doc.qt.io/qt-5.9/qkeysequence.html that QKeySequence("Ctrl++") would need to contain QKeySequence::ZoomIn from http://doc.qt.io/qt-5.9/qkeysequence.html#StandardKey-enum in every code point for maximum keyboard support. This includes a few others unmentioned and not just Ctrl + +.

elcste commented 7 years ago

From a quick look-see, Firefox for example behaves the same.

Firefox zooms for both control + and control = .

Martii commented 7 years ago

Hmmm https://github.com/QupZilla/qupzilla/blob/3c60b8417a7e2ab2c831a907aaf54dcd94ab459f/src/lib/app/mainmenu.cpp#L492-L496 is an abstract so this could present an issue with getting maximum keyboard support.

Chiitoo commented 7 years ago

Firefox zooms for both control + and control = .

Thanks for that note, elcste. I had either completely forgotten about it, or never knew before now. :] .