search

QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.11k stars 349 forks source link

Tab loading animation doesn't stop with Qt 5.10 #2479

Closed antonio-rojas closed 6 years ago

antonio-rojas commented 6 years ago

When running on Qt 5.10, the tab loading animation (throbber) is never replaced by the page icon for some websites. It seems to affect mostly pages that auto-refresh, such as twitter or facebook. No issues with Qt 5.9.

nowrep commented 6 years ago

Hm, so I guess loading signals are broken again on 5.10

Chiitoo commented 6 years ago

Looks like QTBUG-65223: [REG 5.9 -> 5.10] loadStarted is emitted twice when loading link with anchor

The-Compiler commented 6 years ago

FWIW you can listen to loadProgress (with progress 100) instead of loadFinished as a workaround: https://github.com/qutebrowser/qutebrowser/pull/3427/files

Also, if you (plural) have a Qt JIRA account, maybe vote for the bug in the hope someone actually looks at those :wink:

nowrep commented 6 years ago

@The-Compiler Thanks for the workaround! Voted on the bug.

antonio-rojas commented 6 years ago

Any reason why this is only enabled for 5.10.0? The issue is still not fixed in qtwebengine 5.10.1 and the workaround no longer works

Martii commented 6 years ago

@antonio-rojas

It seems to affect mostly pages that auto-refresh, such as twitter or facebook.

...

The issue is still not fixed in qtwebengine 5.10.1 and the workaround no longer works

Any particular twitter feed that you care to share for testing purposes. I just tested a known one with my Linux distro and the twitter page tab throbber does stop on the twitter favicon. OS X will be next after its massive download and recompile.

Thanks.

ghost commented 6 years ago

Any reason why this is only enabled for 5.10.0?

Because only that version was available when the bug was fixed (workaround). Since 5.10.1 has been released just few days ago and the issue persists (i can confirm that), it will be adjusted for the new version as well.

antonio-rojas commented 6 years ago

Because only that version was available when the bug was fixed (workaround).

Sure, but generally fixes are made future-proof. Would the workaround have any side effects if it were used with a version of Qt that doesn't have this issue? (I'd be interested to know in case this is fixed in Qt and I want to backport the fix)

nowrep commented 6 years ago

Yes, it have side effects - loadFinished is emitted twice on pages where it would work correctly without this workaround.

The-Compiler commented 6 years ago

Might be more than twice - for example, on https://translate.google.com/ it's triggered every time the URL changes because a character was entered.

Martii commented 6 years ago

for example, on https://translate.google.com/ it's triggered every time the URL changes because a character was entered.

Ahh good a test target and one that triggers it here. Thank you. 😸

Linux distro at effcd37 CONFIRMED

OS X latest at 64c8e9b NOT PRESENT Linux distro at 64c8e9b NOT PRESENT