search

QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.11k stars 350 forks source link

Visual C++ Redistributable Missing File #2505

Closed Martii closed 6 years ago

Martii commented 6 years ago

So I was in my Win10 x64 vbox and was updating QupZilla from 2.1.2 to 2.2.1 and encountered this (MSVCR120.dll):

Missing MSVCR120.dll

From lots of past experience I realize that this can usually be remedied by installing the Visual C++ Redistributable Packages for Visual Studio 2013 but I was wondering if QupZilla is supposed to distribute these with the application?

nowrep commented 6 years ago

What version did you install? I just checked x86 Installer + Portable and there is no issue, it doesn't link to msvcr120.dll.

Martii commented 6 years ago

@nowrep

What version did you install?

 

...my Win10 x64 vbox...

This would indicate the 64 bit version from above. :)

... updating QupZilla from 2.1.2 to 2.2.1...

Also from above.

I didn't get this message on a clients machine with Windows 7 x64 (but he is also running VS of many versions so it's probably already there)... just in this clean VM of Windows 10.

srazi commented 6 years ago

Indeed, it is loaded by OpenSSL.

image

I will try to find a fix without hard coding DLL version.

srazi commented 6 years ago

Fixed by 78a72629174351708b2c5052c6e367718f79f8f1 @nowrep Other issues of Windows installer also are fixed and now Windows builds use Qt-5.9.2. So, if you want to re-push tag v2.2.1 to update installers then please at first delete installers from release v2.2.1.

nowrep commented 6 years ago

@srazi I'll just make new version, thanks.