QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.12k stars 347 forks source link

Just some gnome deprecation warnings #2530

Open tsujan opened 6 years ago

tsujan commented 6 years ago

Not that any of this might be important (not to me; I don't use Gnome) but just for the record:

While the latest QupZilla was being compiled, deprecation warnings were issued about gnome functions in the terminal:

warning: ‘GnomeKeyringResult gnome_keyring_item_set_attributes_sync(const char*, guint32, GnomeKeyringAttributeList*)’ is deprecated: Use 'secret_item_set_attributes_sync' instead [-Wdeprecated-declarations]
warning: ‘void gnome_keyring_attribute_list_free(GnomeKeyringAttributeList*)’ is deprecated: Use 'g_hash_table_unref' instead [-Wdeprecated-declarations]
warning: ‘GnomeKeyringResult gnome_keyring_item_delete_sync(const char*, guint32)’ is deprecated: Use 'secret_item_delete_sync' instead [-Wdeprecated-declarations]
warning: ‘GnomeKeyringResult gnome_keyring_find_itemsv_sync(GnomeKeyringItemType, GList**, ...)’ is deprecated: Use 'secret_service_search_sync' instead [-Wdeprecated-declarations]
warning: ‘void gnome_keyring_found_list_free(GList*)’ is deprecated [-Wdeprecated-declarations]
...
nowrep commented 6 years ago

This plugin should be ported to libsecret to fix those warnings. As it is now, it should still work fine except the build warnings.

ghost commented 6 years ago

I can confirm that it works fine.

ghost commented 6 years ago

@nowrep Is it possible this plugin to be made to ask the password only if it's really needed. Now it ask the password right after first start of QupZilla, but if i don't have to login anywhere, why the keyring should be unlocked?

And some off topic: I saw the following in Fuckingfox, but i find it useful, so what you think about that: capture du 2017-12-30 15 54 30

nowrep commented 6 years ago

It's not possible as it is implemented now because it stores all data (site, username, form data and password) in keyring so it needs to be queried the first time page finishes loading. Ideally you would have your keyring already opened by other app / automatically on login so this shouldn't be issue at all.