Crash

[ghost]

Crash when trying to open youtube link from embeded video

Crash-2018-01-06T21:37:35.txt gdb_backtrace_include_garbage.txt

QupZilla 2.2.3 (748aa31) QtWebEngine 5.9.3

[nowrep]

Can you reproduce it?

[ghost]

Absolutely, also with clean profile.

[ghost]

@nowrep It is non reproducible with disabled Adblock.

[nowrep]

Yeah I can reproduce it myself.

[nowrep]

Alright, apply this for now and I'll fix it tomorrow.

diff --git a/src/lib/adblock/adblockicon.cpp b/src/lib/adblock/adblockicon.cpp
index 86fc6035..11b03d59 100644
--- a/src/lib/adblock/adblockicon.cpp
+++ b/src/lib/adblock/adblockicon.cpp
@@ -40,7 +40,7 @@ AdBlockIcon::AdBlockIcon(QObject *parent)
     connect(this, &AbstractButtonInterface::clicked, this, &AdBlockIcon::clicked);
     connect(this, &AbstractButtonInterface::webPageChanged, this, &AdBlockIcon::webPageChanged);
     connect(AdBlockManager::instance(), &AdBlockManager::enabledChanged, this, &AdBlockIcon::updateState);
-    connect(AdBlockManager::instance(), &AdBlockManager::blockedRequestsChanged, this, &AdBlockIcon::blockedRequestsChanged);
+    // connect(AdBlockManager::instance(), &AdBlockManager::blockedRequestsChanged, this, &AdBlockIcon::blockedRequestsChanged);
 }

 QString AdBlockIcon::id() const

[ghost]

Ah, thanks! It is not important, i just wanted to inform you. Have a good night!

[ghost]

@nowrep Everything looks fine at all, but the browser generates a back-trace on close. Crash-2018-01-07T20:48:49.txt

[nowrep]

@cranes-bill Yeah, I've already fixed that but didn't push yet.

[ghost]

Aaah, sorry!